Homework 4, Feedback.

• Redo due May 1.
  • EVERYTHING must be fixed.
  • And see note about out of bounds index error later in notes.
• Why does this happen?

  Concentration
  NEW TURN
       0  1  2  3
     +--+--+--+--+
    0|XX|XX|XX|XX|
     +--+--+--+--+
    1|XX|XX|XX|XX|
     +--+--+--+--+
    2|XX|XX|XX|XX|
     +--+--+--+--+
    3|XX|XX|XX|XX|
     +--+--+--+--+
    4|XX|XX|XX|XX|
     +--+--+--+--+
  
  
  Enter a coordinate
     x: 999999
     y: 999999
  Segmentation fault (core dumped) 

  • If it happens on redo, NO CREDIT and I cut your score in half.
    • Possibly your final score.
  • How many of you are in cybersecurity right now?
  • How many of you took 230 with a discussion of array out of bounds index errors?
  • I am not sure that I tested this for everyone, but I WILL ON REDO.
• What is this?

  if (column < width && row < height) {
         index = ((row * rowLength) + column);
  } else if (column >=width || row >= height) {
         index = ((row * rowLength) + column) + 1000;
  } 

  • If the coordinates are bad, make them worse?
    • Methinks this calls for an exception, not a compounding of the mistake.
    • NEVER EVER EVER knowingly set an array index to a bad value.
    • Look how long it took us to get you to pay attention to compiler warnings.
    • Do you think your class users will check your error codes?
  • The duplicate computation makes me sad.

  • index = ((row * rowLength) + column);
    if (row >= height or colum >= width) {
       index += 1000;
    } 

  • The weird if makes me sad.
    • Is there a need for the second if? Isn't it just a restatement of the first if?
    • Just make it an else clause.
  • 1000 should be a named constant.
    • Probably SOME_DUMB_CONSTANT_BECAUSE_I_CANT_FIGURE_OUT_WHAT_IS_HAPPENING_SO_I_JUST_THREW_THIS_IN
• Duplicate code!

  coord1 = GetCoord(board);
  board[coord1].Flip();
  PrintCard(board[coord1].GetCard());
  DrawBoard(board);
  
  coord2 = GetCoord(board);
  board[coord2].Flip();
  PrintCard(board[coord2].GetCard());
  DrawBoard(board); 

• Use those enumerations

  •         switch (direction) {
                    case static_cast<DirT>(0):
                            y++;
                            break;
                    case static_cast<DirT>(1):
                            y--;
                            break;
                    case static_cast<DirT>(2):
                            x--;
                            break; 

  • "ChangeCoord moves the coordinate in the given direction, but only if valid."
• When the assignment says "Change and set allow the user to change the coordinate. These should call the underlying board functions. The coordinate class SHOULD NOT implement any board logic."
  • Should the CoordinateT change a coordinate value then? Or should it call board logic to do this?

  • void CoordT::Change(DirT direction){
        if(static_cast<int>(direction) == 1){
            x += 1;
        }
        return;
    } 

• Questions for the collective:

  void CardT::Random(int maxValue) {
      suite = static_cast<SuiteT> (rand() % SUITE_COUNT);
      value = rand() % maxValue + 2;
      return;
  } 

  • Why +2? Do you not like the Ace of whatever?

  • void SquareT::SetCard(CardT c){
        if (cardPresent == false){
            card = c;
            cardPresent = true;
        }
    } 

  • Am I not allowed to change a card in the square?
• Why this?

  • bool SquareT::HasCard() const {
        if(cardPresent){
            return true;
        }
        return false;
    } 

  • Why not this? bool SquareT::HasCard() const { return cardPresent; }