Project 2 Feedback.

• I noticed that I had two different point values listed for the homework.
  • Sorry about that.
  • I went with the higher values as this is more helpful to most people.
• Declare constants for numeric values that might change.
  • The maximum number of cherries
  • The maximum number of players.
  • USE THESE CONSTANTS.
  • Don't build big if statements based on these constants.
  • Think about what would happen if we changed to 20 players or 2000 cherries.
• Several of you have a known logic problem

  • while (ch != 'A' or ch != 'B') {
    } 

  • ch	ch != 'A'	ch != 'B'	(ch != 'A' or ch != 'B'
    'A'	false	true	true
    'B'	true	false	true
    anything else	true	true	true

  • you really want an and.
  • This is related to DeMorgan's Law.
  • not (a or b) = not a and not b
• Do not declare global variables
  • We have discussed this.
• Do not take actions based on bad input, ever
• You probably don't need both a basket and a tree.
• This is a bad construct

  • if (condition) {
    }
    
    if (not condition) {
    }
              

  • Use an else. You are less likely to have an error
• Learn to use setw
• Don't do this

  • if (spin == SpinnerT::ONE_CHERRY) {
         bunch of actions with the number 1 
    } else if (spin == SpinnerT::TWO_CHERRY)
         same actions, but with the number 2
    } else if (spin == SpinnerT::TWO_CHERRY)
         same actions, but with the number 3
         ...  

  • First of all use a case.
  • Secondly, write a single function that takes a parameter

  • // I am not overjoyed with this code. see below.
    switch (spin) {
         case SpinnerT::ONE_CHERRY:
               AddCherries(player, 1); 
               break;
         case SpinnerT::TWO_CHERRY:
               AddCherries(player, 2); 
               break;
         case SpinnerT::THREE_CHERRY:
               AddCherries(player, 3); 
               break;
               ....
         case SpinnerT::BIRD:
         case SpinnerT::DOG:
               DeleteCherries(player, 2, SpinnerTToString(spinner);
               break;
    }
    ...  

  • Or better yet

  • if (spin <= SpinnerT::FOUR_CHERRY) {
        AddCherries(player, spin);
    } else {
        DeleteCherries(player, spin);
    } 

• Do NOT do this

  spin = SpinSpinner();
  intSpin = SpinnerTToInt(spin)
  if (intSpin ...) 

• I don't like

  • if (player.human == true)
    if (player.human == false) 

  • I don't find these literate.
  • Try

  • if (player.isHuman)
    if (not player.isHuman) 

• Don't do this

  • if (player.isHuman) {
        line 1
        line 2
        unique line for human
        line 3
        line 4
    } else {
        line 1
        line 2
        unique line for computer
        line 3
        line 4
    } 

  • Do this

  • line 1
    line 2
    if (player.isHuman) {
        unique line for human
    } else {
        unique line for computer
    }
    line 3
    line 4